Skip flaky tests on jruby #3507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
approved these changes
Apr 10, 2020
4 tasks
Contributor
|
It seems like JRuby (jruby-9.2.11.0) offers resistance to this: https://github.com/rubygems/rubygems/pull/3507/checks?check_run_id=577724865#step:4:73 |
Contributor
Author
|
Oh, yeah, it should be fixed by #3508, since the |
Contributor
Author
|
Since #3508 might've fixed something (I'm not confident at all but who knows), I'll leave this PR opened until the flaky happens one more time, and then merge it. If on the contrary it doesn't happen again, I'll close this after a while. |
I believe these are most certainly due to a problem outside of rubygems. I'm skipping these at least until webrick officially supports jruby (defining "officially" as "webrick's CI passes on jruby").
deivid-rodriguez
force-pushed
the
skip_tests_using_webrick_on_jruby
branch
from
b408c81 to
4fca025
Compare
Contributor
Author
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a temporary workaround for #3451.
It seems most likely a problem in either jruby or webrick, so until fixed upstream let's skip it so that it doesn't get in the middle.
Related upstream tickets:
ruby/webrick#40
jruby/jruby#6171
Tasks:
I will abide by the code of conduct.