Skip to content

All tests passing on JRuby extension #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Feb 20, 2025
Merged

All tests passing on JRuby extension #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c26bed6
Use modify that clears codeRange
headius Feb 18, 2025
667acea
Check incompatible encodings as in C
headius Feb 18, 2025
8f955ec
Check readability during iteration
headius Feb 18, 2025
7403244
Advance pos before yielding, in case of early return
headius Feb 18, 2025
ceda9e5
Align init and encoding setup with C logic
headius Feb 18, 2025
ae66f00
Handle zero-length pread as in C
headius Feb 18, 2025
a517fd6
Only update buffer encoding if not binary
headius Feb 18, 2025
571a36b
Support the NULL StringIO as in C
headius Feb 19, 2025
26436e6
Return zero from truncate
headius Feb 19, 2025
1bcc551
Duplicate unget logic for buffer management from C
headius Feb 19, 2025
70fbb46
Use long math to detect int overflow in expand
headius Feb 19, 2025
8967fd8
Modify string and clear coderange after write
headius Feb 19, 2025
9dbb575
Align write encoding check with C
headius Feb 19, 2025
7a2e141
Don't ignore failures on JRuby anymore
headius Feb 19, 2025
18c7d46
Clarify to which C function these correspond
headius Feb 19, 2025
247173b
Add rb_enc_check that ignores empty str1
headius Feb 19, 2025
4ed7b05
Add JRuby to windows CI
headius Feb 19, 2025
dbe236f
Init with default external encoding
headius Feb 19, 2025
2f83c47
Minor tweaks to align getline behavior with C
headius Feb 19, 2025
7108323
Handle all initialize forms and modes
headius Feb 19, 2025
ee25a6d
Guard access to ptr behind frozen check
headius Feb 20, 2025
ac375b6
Modify string even if it didn't expand
headius Feb 20, 2025
88d5e0c
Use newer rb_enc_check from JRuby if available
headius Feb 20, 2025
48808db
Merge branch 'master' into stringio_green
headius Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
if: >-
matrix.ruby != 'truffleruby-head'
run: bundle exec rake
continue-on-error: ${{ startsWith(matrix.ruby, 'jruby') }}
- name: Install gem
run: |
gem install pkg/*.gem
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
with:
engine: cruby
min_version: 2.7
versions: '["mswin", "mingw"]'
versions: '["mswin", "mingw", "jruby-head"]'

build:
needs: ruby-versions
Expand Down
Loading