Ensure server port numbers are numeric and ensure they are stored as … #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! I agree that it makes sense to store the port as an integer. |
thesamesam
added a commit
to thesamesam/gentoo
that referenced
this pull request
Apr 1, 2023
- Enable ruby32 - Fix tests Fixing tests was interesting. I very quickly found the upstream commits touching the port deduction/specification bit, but I had no idea why this would've started failing on all Rubies all of a sudden yet. But ended up, after looking through MRI Ruby release notes, figured out it must be somewhere else (it didn't seem to be a backported bundled gem update). It looks like it's actually because of a change in an (undeclared) test dep - dev-ruby/webrick. It was probably ruby/webrick#55 or similar, but enough to satisfy my curiosity anyway. Signed-off-by: Sam James <[email protected]>
thesamesam
added a commit
to thesamesam/gentoo
that referenced
this pull request
Apr 1, 2023
- Enable ruby32 - Fix tests Fixing tests was interesting. I very quickly found the upstream commits touching the port deduction/specification bit, but I had no idea why this would've started failing on all Rubies all of a sudden yet. But ended up, after looking through MRI Ruby release notes, figured out it must be somewhere else (it didn't seem to be a backported bundled gem update). It looks like it's actually because of a change in an (undeclared) test dep - dev-ruby/webrick. It was probably ruby/webrick#55 or similar, but enough to satisfy my curiosity anyway. Signed-off-by: Sam James <[email protected]>
thesamesam
added a commit
to thesamesam/gentoo
that referenced
this pull request
Apr 1, 2023
- Enable ruby32 - Fix tests Fixing tests was interesting. I very quickly found the upstream commits touching the port deduction/specification bit, but I had no idea why this would've started failing on all Rubies all of a sudden yet. But ended up, after looking through MRI Ruby release notes, figured out it must be somewhere else (it didn't seem to be a backported bundled gem update). It looks like it's actually because of a change in an (undeclared) test dep - dev-ruby/webrick. It was probably ruby/webrick#55 or similar, but enough to satisfy my curiosity anyway. Signed-off-by: Sam James <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 1, 2023
- Enable ruby32 - Fix tests Fixing tests was interesting. I very quickly found the upstream commits touching the port deduction/specification bit, but I had no idea why this would've started failing on all Rubies all of a sudden yet. But ended up, after looking through MRI Ruby release notes, figured out it must be somewhere else (it didn't seem to be a backported bundled gem update). It looks like it's actually because of a change in an (undeclared) test dep - dev-ruby/webrick. It was probably ruby/webrick#55 or similar, but enough to satisfy my curiosity anyway. Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…integers
When passing in a "0" for the port number - the port number is not updated as is the intention. Ensuring the port number is stored as an integer solves this.