fix: @jridgewell/sourcemap-codec issue #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c46740 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update modifies dependency versions across several package.json files, primarily upgrading "@llamaindex/tools" to "~0.1.2". Additionally, it adds three sourcemap-related packages to the server package to address TypeScript server startup issues linked to peer dependencies and sourcemap configuration. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Server as @llamaindex/server
participant Sourcemap as Sourcemap Packages
participant TS as TypeScript Server
Dev->>Server: Starts server (with updated dependencies)
Server->>Sourcemap: Loads sourcemap packages
Server->>TS: Initializes TypeScript server
TS-->>Server: Startup succeeds (dependencies and sourcemaps resolved)
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/server/package.json (1)
63-65: Double-check necessity & bundle impact of the new@jridgewell/*packagesThese three packages are often shipped transitively by build tools (e.g. Babel, Next). Adding them explicitly:
- prevents “missing peer” errors – 👍
- but may bloat the published bundle if they get duplicated.
Action items:
- run
pnpm why @jridgewell/sourcemap-codecto confirm no duplicates,- if they end up being build-time only, consider
devDependenciesinstead..changeset/nervous-trainers-pull.md (1)
6-6: Nit: tighten the changeset summaryConsider a more descriptive line, e.g.:
Fix TS-server startup failure caused by peer-dep clashes and missing sourcemap packagesThis helps future readers scanning the changelog.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.changeset/nervous-trainers-pull.md(1 hunks)packages/create-llama/templates/types/llamaindexserver/nextjs/package.json(1 hunks)packages/server/examples/package.json(1 hunks)packages/server/package.json(1 hunks)packages/server/project-config/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:27.046Z
Learning: The LlamaIndexServer class in src/server.ts centralizes server setup, workflow initialization, UI configuration, and custom routing, providing a single entry point for server logic in a Next.js-based application.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: The build process for the TypeScript server package involves multiple steps: cleaning, bunchee compilation to ESM/CJS, Next.js preparation, static asset generation, and preparing assets for Python integration.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: Integration with LlamaIndex Core, OpenAI, and React/Next.js enables document processing, LLM/embedding model usage, and modern frontend development, respectively, forming a comprehensive full-stack architecture.
Learnt from: CR
PR: run-llama/create-llama#0
File: python/llama-index-server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:32:15.730Z
Learning: For UI development, use only supported dependencies (React, shadcn/ui, Lucide React, Tailwind CSS, and LlamaIndex Chat UI) to ensure compatibility and maintainability.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: TypeScript configuration enforces strict type checking, targets ES2022, and uses bundler module resolution, which enhances code quality and compatibility.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: Version synchronization is maintained between TypeScript and Python packages, with shared UI components and styling to ensure consistency across implementations.
packages/server/examples/package.json (6)
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:27.046Z
Learning: The LlamaIndexServer class in src/server.ts centralizes server setup, workflow initialization, UI configuration, and custom routing, providing a single entry point for server logic in a Next.js-based application.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: Integration with LlamaIndex Core, OpenAI, and React/Next.js enables document processing, LLM/embedding model usage, and modern frontend development, respectively, forming a comprehensive full-stack architecture.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: Development environment setup requires Node.js >=16.14.0, Python with the uv package manager, and pnpm for package management, supporting concurrent development across packages.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: The repository is a monorepo combining TypeScript/Node.js and Python components, using pnpm for workspace management and supporting unified development workflows.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/create-llama/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:17.317Z
Learning: The create-llama CLI tool is designed to scaffold RAG (Retrieval-Augmented Generation) applications using a flexible template system that supports multiple frameworks (NextJS, Express, FastAPI), model providers (OpenAI, Anthropic, Groq, Ollama), and vector databases (Mongo, Postgres, Pinecone, Milvus, etc.).
Learnt from: CR
PR: run-llama/create-llama#0
File: python/llama-index-server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:32:15.730Z
Learning: For UI development, use only supported dependencies (React, shadcn/ui, Lucide React, Tailwind CSS, and LlamaIndex Chat UI) to ensure compatibility and maintainability.
.changeset/nervous-trainers-pull.md (6)
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:27.046Z
Learning: The LlamaIndexServer class in src/server.ts centralizes server setup, workflow initialization, UI configuration, and custom routing, providing a single entry point for server logic in a Next.js-based application.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: The build process for the TypeScript server package involves multiple steps: cleaning, bunchee compilation to ESM/CJS, Next.js preparation, static asset generation, and preparing assets for Python integration.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: Integration with LlamaIndex Core, OpenAI, and React/Next.js enables document processing, LLM/embedding model usage, and modern frontend development, respectively, forming a comprehensive full-stack architecture.
Learnt from: CR
PR: run-llama/create-llama#0
File: python/llama-index-server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:32:15.730Z
Learning: The LlamaIndexServer class (in llama_index/server/server.py) should be implemented by extending FastAPI and must support workflow factory patterns, UI configuration, automatic file serving, and development features such as CORS and hot reloading.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: End-to-end testing is performed using Playwright in packages/create-llama/e2e/, validating both Python and TypeScript generated projects for correct CLI generation and application functionality.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/create-llama/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:17.317Z
Learning: The create-llama CLI tool is designed to scaffold RAG (Retrieval-Augmented Generation) applications using a flexible template system that supports multiple frameworks (NextJS, Express, FastAPI), model providers (OpenAI, Anthropic, Groq, Ollama), and vector databases (Mongo, Postgres, Pinecone, Milvus, etc.).
packages/create-llama/templates/types/llamaindexserver/nextjs/package.json (11)
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:27.046Z
Learning: The LlamaIndexServer class in src/server.ts centralizes server setup, workflow initialization, UI configuration, and custom routing, providing a single entry point for server logic in a Next.js-based application.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: Integration with LlamaIndex Core, OpenAI, and React/Next.js enables document processing, LLM/embedding model usage, and modern frontend development, respectively, forming a comprehensive full-stack architecture.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/create-llama/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:17.317Z
Learning: The create-llama CLI tool is designed to scaffold RAG (Retrieval-Augmented Generation) applications using a flexible template system that supports multiple frameworks (NextJS, Express, FastAPI), model providers (OpenAI, Anthropic, Groq, Ollama), and vector databases (Mongo, Postgres, Pinecone, Milvus, etc.).
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: Templates in packages/create-llama/templates/ are organized into types (base project structures) and components (reusable across frameworks), supporting multiple frameworks such as Next.js, Express, and FastAPI.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: The build process for the TypeScript server package involves multiple steps: cleaning, bunchee compilation to ESM/CJS, Next.js preparation, static asset generation, and preparing assets for Python integration.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: End-to-end testing is performed using Playwright in packages/create-llama/e2e/, validating both Python and TypeScript generated projects for correct CLI generation and application functionality.
Learnt from: CR
PR: run-llama/create-llama#0
File: python/llama-index-server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:32:15.730Z
Learning: The LlamaIndexServer class (in llama_index/server/server.py) should be implemented by extending FastAPI and must support workflow factory patterns, UI configuration, automatic file serving, and development features such as CORS and hot reloading.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: Development environment setup requires Node.js >=16.14.0, Python with the uv package manager, and pnpm for package management, supporting concurrent development across packages.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: Agent creation across all examples leverages the agent() function from @llamaindex/workflow, always passing an array of tools, which standardizes agent configuration.
Learnt from: CR
PR: run-llama/create-llama#0
File: python/llama-index-server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:32:15.730Z
Learning: For UI development, use only supported dependencies (React, shadcn/ui, Lucide React, Tailwind CSS, and LlamaIndex Chat UI) to ensure compatibility and maintainability.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: The repository is a monorepo combining TypeScript/Node.js and Python components, using pnpm for workspace management and supporting unified development workflows.
packages/server/project-config/package.json (4)
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:27.046Z
Learning: The LlamaIndexServer class in src/server.ts centralizes server setup, workflow initialization, UI configuration, and custom routing, providing a single entry point for server logic in a Next.js-based application.
Learnt from: CR
PR: run-llama/create-llama#0
File: python/llama-index-server/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:32:15.730Z
Learning: For UI development, use only supported dependencies (React, shadcn/ui, Lucide React, Tailwind CSS, and LlamaIndex Chat UI) to ensure compatibility and maintainability.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: Integration with LlamaIndex Core, OpenAI, and React/Next.js enables document processing, LLM/embedding model usage, and modern frontend development, respectively, forming a comprehensive full-stack architecture.
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: Development environment setup requires Node.js >=16.14.0, Python with the uv package manager, and pnpm for package management, supporting concurrent development across packages.
packages/server/package.json (2)
Learnt from: CR
PR: run-llama/create-llama#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:05.815Z
Learning: The build process for the TypeScript server package involves multiple steps: cleaning, bunchee compilation to ESM/CJS, Next.js preparation, static asset generation, and preparing assets for Python integration.
Learnt from: CR
PR: run-llama/create-llama#0
File: packages/server/examples/CLAUDE.md:0-0
Timestamp: 2025-06-27T07:31:35.770Z
Learning: TypeScript configuration enforces strict type checking, targets ES2022, and uses bundler module resolution, which enhances code quality and compatibility.
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: typescript (22, ubuntu-22.04, nextjs, none)
- GitHub Check: typescript (22, windows-latest, nextjs, llamacloud)
- GitHub Check: python (20, 3.11, windows-latest, fastapi, llamacloud)
- GitHub Check: lint
- GitHub Check: typescript (22, ubuntu-22.04, nextjs, llamacloud)
- GitHub Check: python (20, 3.11, ubuntu-22.04, fastapi, none)
- GitHub Check: typescript (22, windows-latest, nextjs, none)
- GitHub Check: python (20, 3.11, ubuntu-22.04, fastapi, llamacloud)
- GitHub Check: typescript (22, macos-latest, nextjs, llamacloud)
- GitHub Check: typescript (22, macos-latest, nextjs, none)
- GitHub Check: python (20, 3.11, windows-latest, fastapi, none)
- GitHub Check: python (20, 3.11, macos-latest, fastapi, none)
- GitHub Check: python (20, 3.11, macos-latest, fastapi, llamacloud)
- GitHub Check: Unit Tests (ubuntu-latest, 3.9)
- GitHub Check: Unit Tests (windows-latest, 3.9)
🔇 Additional comments (3)
packages/create-llama/templates/types/llamaindexserver/nextjs/package.json (1)
16-16: Verify lock-file + downstream compatibility for the new@llamaindex/toolsrangeThe bump to
~0.1.2looks reasonable and is aligned with the rest of the workspace, but please make sure to:
- regenerate / commit the workspace lock-file (
pnpm-lock.yaml) so CI doesn’t pick up mismatched versions,- run a quick smoke-test –
@llamaindex/tools0.1.x introduced some minor API tweaks.packages/server/examples/package.json (1)
13-13: Keep the examples in sync with the templateGood catch updating the example project as well. Same due-diligence applies: confirm the lock-file is updated and the example still runs (
pnpm dev).packages/server/project-config/package.json (1)
48-48: Project config dependency bump mirrors other workspacesNo functional concerns – just remember to run
pnpm -r exec pnpm install --lockfile-only(or similar) so every workspace sees the same transitive tree.
thucpn
commented
Jun 30, 2025
Comment on lines
+63
to
+65
| "@jridgewell/sourcemap-codec": "1.5.0", | ||
| "@jridgewell/gen-mapping": "0.3.8", | ||
| "@jridgewell/trace-mapping": "0.3.25", |
Collaborator
Author
There was a problem hiding this comment.
install fixed version of these map packages to fix jridgewell/sourcemaps#31
marcusschiesser
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores