Skip to content

Add a few simplifications and definedness preservation attributes #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 19, 2025
Merged

Add a few simplifications and definedness preservation attributes #855

merged 8 commits into from
Nov 19, 2025

Conversation

@jberthold
Copy link
Member

@jberthold jberthold commented Nov 19, 2025

  • declares that #intAsType and littleEndianFromBytes equations preserve definedness (booster should apply them)
  • removes round-trips from (symbolic) discriminant to variantIdx and back
  • simplifies repeated bit shifts and asserts magnitude limit for byte-sliced values

@jberthold jberthold marked this pull request as ready for review November 19, 2025 04:22
dkcumming
dkcumming approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@jberthold jberthold merged commit 936833e into master Nov 19, 2025
7 checks passed
@jberthold jberthold deleted the HOTFIX-a-few-simplifications branch November 19, 2025 05:16
@jberthold jberthold mentioned this pull request Nov 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkcumming dkcumming dkcumming approved these changes

@Stevengre Stevengre Awaiting requested review from Stevengre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jberthold @dkcumming