Pmarks/fix no default features #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 125329514
💛 - Coveralls |
brainstorm
requested changes
Jun 5, 2020
There was a problem hiding this comment.
Thanks Patrick and sorry if I did break things for you :-S Looking through CI, it seems that libcurl is not happy about those changes though?: https://github.com/rust-bio/rust-htslib/pull/207/checks?check_run_id=740294285#step:9:138
|
Looks like htslib now requires running `./configure` in order to switch off
curl -- hfile_libcurl.o gets included unconditionally in the Makefile. So
I don't think users can actually switch off curl right now. I'll take a
closer look. We may need another sed rule to fixup the makefile in this
case I guess?
…On Thu, Jun 4, 2020 at 6:34 PM Roman Valls Guimera ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks Patrick and sorry if I did break things for you :-S Looking through
CI, it seems that libcurl is not happy about those changes though?:
https://github.com/rust-bio/rust-htslib/pull/207/checks?check_run_id=740294285#step:9:138
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#207 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALGA2TPBPCETJQHPI6R6TRVBDQ5ANCNFSM4NTAZEKA>
.
--
Patrick Marks
Senior Director, Computational Biology
[email protected] <[email protected]>
[image: 10x Genomics] <http://www.10xgenomics.com/>
Office 925 123 4567 | Mobile 408 123 4567
6230 Stoneridge Mall Road
Pleasanton, CA 94588-3260 | 10xgenomics.com <http://www.10xgenomics.com/>
|
|
superseded by #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure all the optional features can actually be switched off.