Add raw context getter to Secp256k1 struct #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Mar 1, 2019
Member
apoelstra
left a comment
apoelstra
left a comment
There was a problem hiding this comment.
ACK. How quickly do you need this? Our next version will be a major bump because we increased the minimum compiler version and updated some dependencies. I can backport if need be.
Collaborator
Author
|
Medium soon. Can wait for the next major version. |
Collaborator
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables extending the Secp256k1 with more cryptographic algorithms outside of this crate. In particular, I'd like to use algorithms in secp256k1-zkp with this crates' Secp256k1. For example, this is how schnorrsig could be added to a rust-secp256k1-zkp crate: jonasnick/rust-secp256k1-zkp@2cd9bc4#diff-378891ea32c1e0e815ba44b3c9dfaa90R110