Skip to content

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jul 22, 2020

This is #140 applied to the Pwm trait as well, since the same concerns apply. Follows up on #236.

PWM is often implemented in a buffered way to allow glitch-free
operation; as a result, implementing a strict "you get what you last
set" is not feasible for some implementations.
@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 22, 2020

Build succeeded:

@bors bors bot merged commit d81cf7c into rust-embedded:master Jul 22, 2020
@eldruin eldruin deleted the pwm-trait-get-old-ok branch July 22, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Review is incomplete T-hal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants