Missing std io error impls for ReadExactError & WriteAllError
#475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want to release `embedded-io` 1.0 and the adapters live there, we can't make any breaking changes to them after release. Putting them in a separate crate allows doing breaking changes without breaking everyone using the IO traits.
Needed for namespaced features (`dep:` in Cargo.toml)
MabezDev
force-pushed
the
missing-std-io-error-impls
branch
3 times, most recently
from
fd19c0b to
42a3f94
Compare
|
with the From impls I added, With that I think it's less critical to share it, I'd rather not expose it as public API. |
MabezDev
force-pushed
the
missing-std-io-error-impls
branch
4 times, most recently
from
9bb047a to
9813946
Compare
- Add `ReadExactError` for `std::io::Error` - Add `WriteAllError` for `std::io::Error`
MabezDev
force-pushed
the
missing-std-io-error-impls
branch
from
9813946 to
39d500d
Compare
|
Ah, good point! Changed :). |
|
Incorporated into #472. Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently depends on changes from #472.
I don't think the move of
to_std_errorto embedded-io will cause any stabilization concerns, it seems unlikely that that signature would change. If it is, I can make this hidden within embedded-io and we can duplicate the function for the adapters crate.