HistoryBuffer: add HistoryBufferView, similar to VecView
#480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
history-buffer-view
branch
from
6145c8f to
3c17fad
Compare
|
replaced by #493 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
viewusesiter::Chain<Slice::Iter, Slice::Iter>as the iterator. This is conceptually simpler, and would also allow exposing the other guarantees of the iterator (Reverse, TrustedLen, Fused) if we want to. This also means the iterator does not have theconst N: usizein its type.We could change
HistoryBuffer::oldest_orderedto use the same iterator, but that would be a breaking change.