feat: Use new asm! instead of llvm_asm! #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Could you also add a change log entry? |
|
@Disasm ok, done |
dkhayes117
reviewed
Aug 12, 2021
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - - Use new `asm!` instead of `llvm_asm!` |
There was a problem hiding this comment.
Do we need the double bullet points ?
There was a problem hiding this comment.
oh, my mistake (|| -_-)
Disasm
approved these changes
Aug 12, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 8, 2022
91: Add inline-asm build to CI, fix build r=dkhayes117 a=Disasm #86 introduced new `asm!` syntax which is enabled with the `inline-asm` feature. However, it doesn't work with current nightly since `asm_const` unstable feature is not enabled. This PR fixes the problem and adds automatic checks to CI. Co-authored-by: Vadim Kaushan <[email protected]>
romancardenas
pushed a commit
that referenced
this pull request
Nov 17, 2023
86: Update CHANGELOG.md r=almindor a=parkero Adds currently unreleased changes for #85 Co-authored-by: parkero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
asmmacro has been merged intonightlyfor some time, whilellvm_asmwill be gradually deprecated and will not enterstable. This PR replacesllvm_asmwithasm, but there are still some minor issues to discuss.My reference are:
In the new
asmfeature, there are several options can set to optimize codes. optionsHowever, I'm not quite sure which options to set. (Sort of newbie to asm in rust)