Change BoxIter to avoid trait objects #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of object-safety for coercion to trait objects (see rust-lang/rfcs#255) affects the previous implementation of BoxIter. It turns out trait objects are not actually necessary to deal with this situation, so the implementation was changed to be generic over the type of iterator instead of the type iterated over.
Member
|
The point of it is to wrap a |
Contributor
Author
|
I see… ok, I simply wanted to make the crate compile again, so I didn't notice I was undermining this struct's entire purpose in doing so. There may be another way though, I haven't looked at this in very much detail. |
Member
|
Fair enough. I've removed the struct for now. Thanks anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of object-safety for coercion to trait objects (see rust-lang/rfcs#255) affects the previous implementation of BoxIter. It turns out trait objects are not actually necessary to deal with this situation, so
the implementation was changed to be generic over the type of iterator instead of the type iterated over.