Add peek_mut and peek_nth_mut to PeekNth
#716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philippe-Cholet
force-pushed
the
peek_nth_mut
branch
from
dea774b to
5524ac2
Compare
which mirror `std::iter::Peekable::peek_mut`.
Use `into_iter` instead to avoid `&&`. I did the same in `PeekNth::peek_nth_mut` to avoid `&mut &`.
Philippe-Cholet
force-pushed
the
peek_nth_mut
branch
from
5524ac2 to
7748ee4
Compare
|
@jswrenn @phimuemue EDIT: I just had to approve to merge this, I'm still discovering the maintainer part. |
Philippe-Cholet
approved these changes
Oct 10, 2023
|
@zachs18 Thanks for this pull request. The quickcheck test is particularly appreciated. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which mirror
std::iter::Peekable::peek_mut.