Update rust/itertools versions in the doc #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
jswrenn
reviewed
Aug 31, 2023
| //! This version of itertools requires Rust 1.32 or later. | ||
| #![doc(html_root_url="https://docs.rs/itertools/0.8/")] | ||
| //! This version of itertools requires Rust 1.36 or later. | ||
| #![doc(html_root_url="https://docs.rs/itertools/0.11/")] |
There was a problem hiding this comment.
I wonder why we have this line at all. I've never written this in any of my other crates. Perhaps it's just a vestige of the past that can be removed without issue?
There was a problem hiding this comment.
Well I did not consider that but it seems so. And in my search I found rust-cli/env_logger#185 helpful. Basically I think it's okay to remove it.
But we still will have to update the MSRV here in the future, unless we expect people to look at the Cargo.toml in which case we should remove that part too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.36 according to
Cargo.toml.And the fixed
html_root_urlupdates all html links we might encounter. I personally do not use it very much but being redirect of0.8felt weird.