Don't raise an error when using non-Arm64EC mangled names if EXPORTAS is set #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
approved these changes
Aug 25, 2025
|
Published as v0.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 0.5.0,
ar_archive_writerlost the ability to Arm64EC mangle C++ names.However, with how
ar_archive_writeris used within the Rust compiler we don't care about the Arm64EC mangled name: the final DLL only uses the unmangled name inEXPORTAS, therefore if we seeEXPORTASset then we can assume that's the correct name and ignore the error that we couldn't mangle thename.