Skip to content

Conversation

willcrichton
Copy link
Contributor

I'm working on getting the scrape examples feature working on docs.rs. However, docs.rs uses cargo rustdoc instead of cargo doc, and right now the --scrape-examples flag is only allowed for cargo doc. So this PR changes it to a -Z flag that can be passed to either command.

@rust-highfive
Copy link

r? @alexcrichton

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 29, 2021

📌 Commit 9fb78cf has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2021
@bors
Copy link
Contributor

bors commented Oct 29, 2021

⌛ Testing commit 9fb78cf with merge 4cc3f4f...

@bors
Copy link
Contributor

bors commented Oct 29, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 4cc3f4f to master...

@bors bors merged commit 4cc3f4f into rust-lang:master Oct 29, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2021
Update cargo

3 commits in 6c1bc24b8b49d4bc965f67d7037906dc199c72b7..94ca096afbf25f670e76e07dca754fcfe27134be
2021-10-24 17:51:41 +0000 to 2021-10-29 14:45:06 +0000
- Chore: prefer `HashMap::from` rather than collecting `Vec` of tuples (rust-lang/cargo#10018)
- Change --scrape-examples flag to -Z rustdoc-scrape-examples (rust-lang/cargo#10017)
- Scrape code examples from examples/ directory for Rustdoc (rust-lang/cargo#9525)
@ehuss ehuss added this to the 1.58.0 milestone Feb 6, 2022
@weihanglo weihanglo added the Z-scrape-examples Nightly: rustdoc scrape examples label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. Z-scrape-examples Nightly: rustdoc scrape examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants