Skip to content

Conversation

@kennystrawnmusic
Copy link

Forked @fee1-dead's fork in order to update and rebase the changes. Should resolve the conflicts that reared their ugly heads since #10330 was submitted.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2022
@kennystrawnmusic
Copy link
Author

Added a couple of line comments to denote the changes made by @fee1-dead that are critical here.

@alexcrichton
Copy link
Member

I'm confused as to the purpose of this because #10330 doesn't have any merge conflicts and is actively blocked on this concern, not merge conflicts.

@bors
Copy link
Contributor

bors commented Feb 22, 2022

☔ The latest upstream changes (presumably #9992) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Thanks for the PR, but I'm going to be stepping down from the Cargo team so I'm going to un-assign myself from this. The Cargo team will help review this when they get a chance.

@alexcrichton alexcrichton removed their assignment Mar 8, 2022
@ehuss
Copy link
Contributor

ehuss commented Apr 11, 2022

I'm going to close this as I don't really know what this is for or why it was submitted.

@ehuss ehuss closed this Apr 11, 2022
@kennystrawnmusic kennystrawnmusic deleted the support-per-pkg-target-w-buildstd branch April 12, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants