Skip to content

Conversation

@weihanglo
Copy link
Member

What does this PR try to resolve?

We are making sure that intra links are checked for all workspace members.
However, some system dependencies of cargo-credential-gnome-secret are not available on all platforms so we test it only on Ubuntu.

How should we test and review this PR?

Wait for all CI job green.

@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2023
@epage
Copy link
Contributor

epage commented Apr 24, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 23ed6d4 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@weihanglo
Copy link
Member Author

Okay I saw this CI failure and split platform condition change away to #12027. Without setting any runs-on or matrix, doc job is run under Ubuntu.

@epage
Copy link
Contributor

epage commented Apr 24, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 77e82ee has been approved by epage

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 24, 2023

⌛ Testing commit 77e82ee with merge 76e498f...

bors added a commit that referenced this pull request Apr 24, 2023
CI: ensure intra links for all members are checked
@bors
Copy link
Contributor

bors commented Apr 24, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2023
@weihanglo
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@bors
Copy link
Contributor

bors commented Apr 24, 2023

⌛ Testing commit 77e82ee with merge e0910a2...

@bors
Copy link
Contributor

bors commented Apr 24, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing e0910a2 to master...

@bors bors merged commit e0910a2 into rust-lang:master Apr 24, 2023
@weihanglo weihanglo deleted the ci2 branch April 24, 2023 17:26
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2023
Update cargo

17 commits in de80432f04da61d98dcbbc1572598071718ccfd2..9e586fbd8b931494067144623b76c37d213b1ab6
2023-04-21 13:18:32 +0000 to 2023-04-25 22:09:11 +0000
- Update home dependency (rust-lang/cargo#12037)
- Warn instead of error in `cargo package` on empty `readme` or `license-file` in manifest (rust-lang/cargo#12036)
- Clarify documentation around test target setting. (rust-lang/cargo#12032)
- fix: apply `[env]` to target info discovery rustc (rust-lang/cargo#12029)
- CI: ensure intra links for all members are checked (rust-lang/cargo#12025)
- chore: make credential dependencies platform-specific (rust-lang/cargo#12027)
- CI: use `-p` to specify workspace members instead of `--manifest-path` (rust-lang/cargo#12024)
- ci: requires `test_gitoxide` and `lockfile` for both bors success and failure (rust-lang/cargo#12026)
- Update windows-sys (rust-lang/cargo#12021)
- Bump libc to 0.2.142 (rust-lang/cargo#12014)
- Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- Improve error message for empty dep (rust-lang/cargo#12001)
- Remove wrong url in benchsuite manifest. (rust-lang/cargo#12020)
- Bump versions of local crates (rust-lang/cargo#12019)
- Add the Win32_System_Console feature since it is used (rust-lang/cargo#12016)
- Update outdated crates.io URLs in publishing guide (rust-lang/cargo#12018)
- Allow named debuginfo options in Cargo.toml (rust-lang/cargo#11958)

r? `@ghost`
@ehuss ehuss added this to the 1.71.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants