Skip to content

Conversation

weihanglo
Copy link
Member

e58b84d changed the shape of response of cargo credential protocol trait,
so credential plugin crates effectively depend on [email protected].
However, [email protected] still depends on[email protected].
They must depend on the same major version of cargo-credential
otherwise incompatible.

This PR

See #13004 for more.

e58b84d changed the shape of response of cargo credential protocol trait,
so credential plugins crates effectively depend on `[email protected]`.
However, `[email protected]` still depends on`[email protected]`.
They must depends on the same major version of `cargo-credential`
otherwise incompatible.

This PR

* bumps the version to `[email protected]`
* bumps the version to `[email protected]`
* bumps the version to `[email protected]`

See rust-lang#13004 for more.
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-credential-provider Area: credential provider for storing and retreiving credentials S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2023
@weihanglo weihanglo changed the title chore: bump cargo-credential-* crates as e58b84d broke stuff chore: bump cargo-credential-* crates as e58b84d broke stuff Nov 19, 2023
@ehuss
Copy link
Contributor

ehuss commented Nov 20, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2023

📌 Commit 36ce6cf has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2023
@bors
Copy link
Contributor

bors commented Nov 20, 2023

⌛ Testing commit 36ce6cf with merge 90a2428...

@bors
Copy link
Contributor

bors commented Nov 20, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 90a2428 to master...

@bors bors merged commit 90a2428 into rust-lang:master Nov 20, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2023
Update cargo

9 commits in 9765a449d9b7341c2b49b88da41c2268ea599720..71cd3a926f0cf41eeaf9f2a7f2194b2aff85b0f6
2023-11-17 20:58:23 +0000 to 2023-11-20 15:30:57 +0000
- Handle $message_type in JSON diagnostics (rust-lang/cargo#13016)
- refactor(toml): Further clean up inheritance (rust-lang/cargo#13000)
- Fix `--check-cfg` invocations with zero features (rust-lang/cargo#13011)
- chore: bump `cargo-credential-*` crates as e58b84d broke stuff (rust-lang/cargo#13010)
- contrib docs: Update now that credential crates are published. (rust-lang/cargo#13006)
- Add more resources to the contrib docs. (rust-lang/cargo#13008)
- Respect `rust-lang/rust`'s `omit-git-hash` (rust-lang/cargo#12968)
- Fix clippy-wrapper test race condition. (rust-lang/cargo#12999)
- fix(resolver): Don't do git fetches when updating workspace members (rust-lang/cargo#12975)
@weihanglo weihanglo deleted the bump-credential branch November 28, 2023 20:13
@ehuss ehuss added this to the 1.76.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-credential-provider Area: credential provider for storing and retreiving credentials S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants