-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore(deps): update msrv #13266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update msrv #13266
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
@epage you made it :) |
PR rust-lang#13266 shows that rust-lang#13265 worked, so extending it to also cover `MSRV:3` updates. Really, I just forgot...
f649463 to
04a377a
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
I believe it is definitely not intended, but bump check didn't catch that other public member crates has got an update of their |
|
I'm fine with that and actually wonder if we should switch the workspace to If we could diff the packages and ignore certain types of changes, that'd be even better :) |
This sounds good and simpler to me 👍🏾 |
Update cargo 14 commits in 2ce45605d9db521b5fd6c1211ce8de6055fdb24e..3e428a38a34e820a461d2cc082e726d3bda71bcb 2024-01-04 18:04:13 +0000 to 2024-01-09 20:46:36 +0000 - refactor: replace `iter_join` with `itertools::join` (rust-lang/cargo#13275) - docs(unstable): doc comments for items and fields (rust-lang/cargo#13274) - crates-io: Set `Content-Type: application/json` only for requests with a body payload (rust-lang/cargo#13264) - fix: only inherit workspace package table if the new package is a member (rust-lang/cargo#13261) - feat(cli): add colors to `-Zhelp` console output (rust-lang/cargo#13269) - chore(deps): update msrv (rust-lang/cargo#13266) - refactor(toml): Make it more obvious to update package-dependent fields (rust-lang/cargo#13267) - chore(ci): Fix MSRV:3 updates (rust-lang/cargo#13268) - chore(ci): Shot-in-the-dark fix for MSRV updating (rust-lang/cargo#13265) - fix: set OUT_DIR for all units with build scripts (rust-lang/cargo#13204) - fix(manifest): Provide unused key warnings for lints table (rust-lang/cargo#13262) - test(manifest): Verify we warn on unused workspace.package fields (rust-lang/cargo#13263) - docs(changelog): Call out cargo-new lockfile change (rust-lang/cargo#13260) - chore: Add dependency dashboard (rust-lang/cargo#13255) r? ghost
We likely don't want to release these packages every 6 months just for an MSRV bump. By moving the MSRV out of the package, `cargo bump-check` will ignore the MSRV bump. Inspired by rust-lang#13266
We likely don't want to release these packages every 6 months just for an MSRV bump. By moving the MSRV out of the package, `cargo bump-check` will ignore the MSRV bump. Inspired by rust-lang#13266
We likely don't want to release these packages every 6 months just for an MSRV bump. By moving the MSRV out of the package, `cargo bump-check` will ignore the MSRV bump. Inspired by rust-lang#13266
We likely don't want to release these packages every 6 months just for an MSRV bump. By moving the MSRV out of the package, `cargo bump-check` will ignore the MSRV bump. Inspired by rust-lang#13266
chore: Make MSRV=N-2 the workspace default ### What does this PR try to resolve? Since we update the MSRV every release, `cargo bump-check` forces the changed packages to be released (#13266). A caveat is that `cargo bump-check` only checks the directory and doesn't do a `.crate` diff, so it misses out of changes to `workspace.package`. Because of our current workspace default, this means every 6 weeks we ship our user-facing packages but not the internal ones. This shifts that so we ship our internal packages every 6 weeks and our internal only when changed. ### How should we test and review this PR? ### Additional information If `rust-version = "auto"` (rust-lang/rfcs#3537) gets approved, then we will only ship packages that actually change
PR rust-lang#13266 shows that rust-lang#13265 worked, so extending it to also cover `MSRV:3` updates. Really, I just forgot...
We likely don't want to release these packages every 6 months just for an MSRV bump. By moving the MSRV out of the package, `cargo bump-check` will ignore the MSRV bump. Inspired by rust-lang#13266
This PR contains the following updates:
1.73->1.75.01.70.0->1.731.75(+1)Release Notes
rust-lang/rust (MSRV:1)
v1.75.0Compare Source
==========================
Language
async fnand return-positionimpl Traitin traits.&mut Tinconstcontexts.usize/isizeexhaustively with half-open ranges.charhas the same size and alignment asu32.match.Compiler
COINDUCTIVE_OVERLAP_IN_COHERENCEto deny, and warn in dependencies.riscv64-linux-androidtarget spec.csky-unknown-linux-gnuabiv2hfi586-unknown-netbsdmipsel-unknown-netbsdRefer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.
Libraries
Waker::clone_fromto avoid cloningWakers unnecessarily.BufReadforVecDeque<u8>.FusedIteratorforDecodeUtf16when the inner iterator does.Not, Bit{And,Or}{,Assign}for IP addresses.DefaultforExitCode.str::SplitInclusive'sDoubleEndedIteratorimplcfg(unix)platforms.Stabilized APIs
Atomic*::from_ptrFileTimesFileTimesExtFile::set_modifiedFile::set_timesIpAddr::to_canonicalIpv6Addr::to_canonicalOption::as_sliceOption::as_mut_slicepointer::byte_addpointer::byte_offsetpointer::byte_offset_frompointer::byte_subpointer::wrapping_byte_addpointer::wrapping_byte_offsetpointer::wrapping_byte_subThese APIs are now stable in const contexts:
Ipv6Addr::to_ipv4_mappedMaybeUninit::assume_init_readMaybeUninit::zeroedmem::discriminantmem::zeroedCargo
[workspace.members]automatically.Cargo.tomlmanifests.Rustdoc
#[repr(transparent)]if it isn't part of the public ABI.Compatibility Notes
constcontexts.Internal Changes
These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.
librustc_driver.sowith BOLT.rustc-codegen-craneliftas rustup component on the nightly channel.v1.74.1Compare Source
===========================
v1.74.0Compare Source
==========================
Language
std::mem::Discriminant<T>does not depend on any lifetimes in Tprivate_in_publiclint withprivate_interfacesandprivate_boundsper RFC 2145.Read more in RFC 2145.
#[repr(Rust)]asyncblocksimpl_trait_projectionsCompiler
PATHoption for--print KIND=PATH*-apple-ios-macabii686-pc-windows-gnullvmas a tier 3 targetLibraries
From<OwnedFd/Handle>for ChildStdin/out/errFrom<{&,&mut} [T; N]>forVec<T>whereT: CloneFrom<[T; N]>forRc<[T]>andArc<[T]>impl TryFrom<char> for u16io_error_otherfeatureSaturatingtypeStabilized APIs
core::num::Saturatingimpl From<io::Stdout> for std::process::Stdioimpl From<io::Stderr> for std::process::Stdioimpl From<OwnedHandle> for std::process::Child{Stdin, Stdout, Stderr}impl From<OwnedFd> for std::process::Child{Stdin, Stdout, Stderr}std::ffi::OsString::from_encoded_bytes_uncheckedstd::ffi::OsString::into_encoded_bytesstd::ffi::OsStr::from_encoded_bytes_uncheckedstd::ffi::OsStr::as_encoded_bytesstd::io::Error::otherimpl TryFrom<char> for u16impl<T: Clone, const N: usize> From<&[T; N]> for Vec<T>impl<T: Clone, const N: usize> From<&mut [T; N]> for Vec<T>impl<T, const N: usize> From<[T; N]> for Arc<[T]>impl<T, const N: usize> From<[T; N]> for Rc<[T]>These APIs are now stable in const contexts:
core::mem::transmute_copystr::is_ascii[u8]::is_asciiCargo
Cargo.toml, stabilize[lints]--keep-goingbuild flag--helpoutputcargo clean, add--dry-runflag and summary line at the endcargo update, make--packagemore convenient by being positionalcargo update, clarify meaning of --aggressive as --recursive--dry-run--packageflags) to resolve ambiguities.cargo/config.toml, merge lists in precedence ordertarget.'cfg(..)'.linkerRustdoc
Compatibility Notes
--externimpl From<{&,&mut} [T; N]> for Vec<T>is known to cause some inference failures with overly-generic code. In those examples using thetuicrate, the combination ofAsRef<_>andInto<Vec>leaves the middle type ambiguous, and the newimpladds another possibility, so it now requires an explicit type annotation.Internal Changes
These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.
None this cycle.
Configuration
📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.