Skip to content

Conversation

@epage
Copy link
Contributor

@epage epage commented Apr 2, 2024

What does this PR try to resolve?

Fixes #13688

How should we test and review this PR?

Additional information

@epage epage marked this pull request as draft April 2, 2024 21:55
@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2024
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be be possible to have definition information included?

@bors
Copy link
Contributor

bors commented May 24, 2024

☔ The latest upstream changes (presumably #13956) made this pull request unmergeable. Please resolve the merge conflicts.

@weihanglo
Copy link
Member

Close in favor of #13956, which is merged.

@weihanglo weihanglo closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-configuration Area: cargo config files and env vars S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhelpful error messages with env-vars that don't set all fields of a config struct

4 participants