Skip to content

Conversation

@Muscraft
Copy link
Member

[lints.cargo] should be removed when publishing/packaging to avoid unintentional MSRV bumps, and this PR makes it so the table is removed.

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2024
@epage
Copy link
Contributor

epage commented Apr 25, 2024

I was wondering if we should just completely strip the table on publish.

This got me thinking, is there a downside to doing it completely? If so, is there a downside to doing it here?

Maybe if forbid is used but that won't work anyways.

If we wanted to include it, we could make it based on your package.rust-version.

@bors
Copy link
Contributor

bors commented Apr 29, 2024

☔ The latest upstream changes (presumably #13713) made this pull request unmergeable. Please resolve the merge conflicts.

@Muscraft
Copy link
Member Author

Muscraft commented May 1, 2024

#13833 supersedes this

@Muscraft Muscraft closed this May 1, 2024
@Muscraft Muscraft deleted the strip-cargo-lints-table branch May 1, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants