Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Jun 22, 2025

Two tests were using .rust_version("1.90.0") for a "newer" Rust, but
this failed in rust-lang/rust#142792 for the start of the real 1.90.0.
Let's bump that to 1.999.0 so we won't have to deal with it for a while.

Two tests were using `.rust_version("1.90.0")` for a "newer" Rust, but
this failed in rust-lang/rust#142792 for the start of the *real* 1.90.0.
Let's bump that to 1.999.0 so we won't have to deal with it for a while.
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2025
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not 100% positive why it was done the way that it was, but this seems like it should fix the issue. I'll post a submodule update.

@ehuss ehuss added this pull request to the merge queue Jun 22, 2025
@ehuss
Copy link
Contributor

ehuss commented Jun 22, 2025

Hm, I would like to also get #15696 merged before the beta branch (otherwise we would need to immediately beta backport it). Would it be ok to wait until tomorrow (or whenever someone gets back online)?

@cuviper
Copy link
Member Author

cuviper commented Jun 22, 2025

Sure, I think it's ok if the 1.89/1.90 branching slips a little bit.

Merged via the queue into rust-lang:master with commit 4832e11 Jun 22, 2025
23 of 24 checks passed
bors added a commit to rust-lang/rust that referenced this pull request Jun 23, 2025
Update cargo

7 commits in 2251525ae503fa196f6d7f9ce6d32eccb2d5f044..84709f085062cbf3c51fa507527c1b2334015178
2025-06-16 22:01:27 +0000 to 2025-06-22 23:58:39 +0000
- Bump cargo-util-schemas version (rust-lang/cargo#15696)
- test(msrv): use a far future "newer" version (rust-lang/cargo#15693)
- Plumb rustc `-Zhint-mostly-unused` flag through as a profile option (rust-lang/cargo#15643)
- Disable lldb test, which seems to be broken due to issues with lldb (rust-lang/cargo#15687)
- docs(contrib): change clap URL to docs.rs/clap (rust-lang/cargo#15682)
- feat: Introduce perma unstable `--compile-time-deps` option for `cargo build` (rust-lang/cargo#15674)
- fix: Failing tests on rustc nightly (rust-lang/cargo#15679)
@rustbot rustbot added this to the 1.89.0 milestone Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants