docs: add pagetoc support for The Cargo Book #15852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've already saw rustc and rustc-dev-guide adopting this. Since The Cargo Book is more like a reference manual, so would largely benefit from the toc on page. Ref: <rust-lang/rust#140113>.
rustbot
added
A-documenting-cargo-itself
|
r? ehuss as you're the mdbook maintainer :) |
|
Also during this I found in Semver compatibility chapter some sections have smaller headers. Not sure if it is intentional. 
|
|
mdbook has added native navigation for in-page sections. I was wondering if we could hold off on this and wait until we transition to the new version? |
|
Totally. Looking forwards to it! |
rustbot
removed
the
S-waiting-on-review
|
Or just close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
We've already saw rustc and rustc-dev-guide adopting this. Since The Cargo Book is more like a reference manual, so would largely benefit from the toc on page.
Ref: rust-lang/rust#140113.
How to test and review this PR?
I didn't make it for contrib doc because that one doesn't have long one page docs, and I hope the feature will eventually upstream into mdbook 😆.
Some screenshots