Skip to content

fix: Fixed nightly tests failing due to unused_variables lint #16098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
+9 −8
Merged

fix: Fixed nightly tests failing due to unused_variables lint #16098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac59761
fix: Fixed nightly tests failing due to unused_variables lint
ranger-ross Oct 13, 2025
920cf6f
chore: Disabled closure_immutable_outer_variable rustfix test
ranger-ross Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/rustfix/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "rustfix"
version = "0.9.3"
version = "0.9.4"
authors = [
"Pascal Hertleif <[email protected]>",
"Oliver Schneider <[email protected]>",
Expand Down
9 changes: 5 additions & 4 deletions crates/rustfix/tests/parse_and_replace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,11 @@ macro_rules! run_test {
};
}

run_test! {
closure_immutable_outer_variable,
"closure-immutable-outer-variable.rs"
}
// NOTE: Temporarily disabled due to failures on nightly. Fix tracked in #16097
// run_test! {
// closure_immutable_outer_variable,
// "closure-immutable-outer-variable.rs"
// }
run_test! {dedup_suggestions, "dedup-suggestions.rs"}
run_test! {E0178, "E0178.rs"}
run_test! {handle_insert_only, "handle-insert-only.rs"}
Expand Down
4 changes: 2 additions & 2 deletions tests/testsuite/future_incompat_report.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ fn incompat_in_local_crate() {
[WARNING] unused variable: `x`
...

[WARNING] `foo` (lib) generated 1 warning
[WARNING] `foo` (lib) generated 1 warning[..]
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
[WARNING] the following packages contain code that will be rejected by a future version of Rust: foo v0.0.0 ([ROOT]/foo)
[NOTE] to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
Expand All @@ -88,7 +88,7 @@ fn incompat_in_local_crate() {
[WARNING] unused variable: `x`
...

[WARNING] `foo` (lib) generated 1 warning
[WARNING] `foo` (lib) generated 1 warning[..]
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
[WARNING] the following packages contain code that will be rejected by a future version of Rust: foo v0.0.0 ([ROOT]/foo)
[NOTE] this report can be shown with `cargo report future-incompatibilities --id 1`
Expand Down