Skip to content

Conversation

@shahn
Copy link

@shahn shahn commented Apr 28, 2017

This is to fix a part of #3966. I am not sure if the semantics are actually correct or if it's even more confusing, please consider that before merging :)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matklad
Copy link
Contributor

matklad commented Apr 28, 2017

I believe the docs are technically correct, albeit a bit confusing.

Membership is infered based on path dependencies. That is, if the root of workspace has a path dependency it is included as a member of the workspace, even if it is not in members list.

In case of a virtual manifest, you don't have any dependencies, so the set of inferred members is empty.

So what we want to say here is:

"additional non path-dependency members for usual manifest and all members for vritual manifest".

Not sure how to express this clearly and concisely :)

@alexcrichton
Copy link
Member

ping @shahn, any thoughts on the comments from @matklad?

@shahn
Copy link
Author

shahn commented May 11, 2017

Will provide new wording, but not before next Monday, been a busy week. Sorry for the delay. If your policy is to close in the interim, please go ahead and I'll reopen/make a new issue later

@alexcrichton
Copy link
Member

No worries was just curious for an update, thanks!

@bors
Copy link
Contributor

bors commented May 16, 2017

☔ The latest upstream changes (presumably #3979) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Closing due to inactivity, but please feel free to resubmit!

bors added a commit that referenced this pull request Sep 14, 2017
Fix confusing error and docs wrt. virtual manifests

Fixes #3966

Contains updated version of #3967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants