Don't require the serde feature of url
#7374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ends up meaning that in full crate compiles that `url` doesn't wait for `serde` to finish, which in turn enables crates like `git2` to start sooner!
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 2f79b20 has been approved by |
bors
added
S-waiting-on-bors
Contributor
bors
added a commit
that referenced
this pull request
Sep 17, 2019
Don't require the `serde` feature of `url` Ends up meaning that in full crate compiles that `url` doesn't wait for `serde` to finish, which in turn enables crates like `git2` to start sooner!
Contributor
|
☀️ Test successful - checks-azure |
bors
added a commit
that referenced
this pull request
Sep 19, 2019
Fix some duplicate artifact problems. The recent cargo update failed because of duplicate artifacts with rls. `tar` should mirror what the main manifest contains. Partially revert #7374 by adding `serde` back to `url`. Unfortunately the `lsp-types` crate (used by rls) needs this feature. Unless anyone has a good idea on how to handle that, I don't think it can be removed. Unblocks cargo update, which I'd like to get done before the beta branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ends up meaning that in full crate compiles that
urldoesn't wait forserdeto finish, which in turn enables crates likegit2to startsooner!