fix mdbook test with ```ignore #7832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
requested changes
Jan 26, 2020
| First, let’s take a look at the directory structure of this package: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```text |
| Like above, let’s first take a look at the package layout: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```text |
| layout of this scenario: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```text |
| actively denying third party access. To check this, you can go to: | ||
|
|
||
| https://github.com/organizations/:org/settings/oauth_application_policy | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```text |
| environment variable will accomplish the same thing as defining a config file: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```text |
| Example: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```sh |
| component: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```console |
| Usage looks like: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```console |
| of these crates, then you can pass an argument to `-Zbuild-std` as well: | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```console |
| takes, and tracks concurrency information over time. | ||
|
|
||
| ``` | ||
| ```ignore |
There was a problem hiding this comment.
Suggested change
| ```ignore | |
| ```sh |
|
☔ The latest upstream changes (presumably #7823) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
|
I'm going to close, as I haven't heard back in a while. Feel free to reopen with the suggested changes, or open new PR if you're still interested. |
bors
added a commit
that referenced
this pull request
Sep 4, 2020
fix mdbook test with ```ignore/text/sh/console I revitalized the dead PR #7832 sorry about the delay testing is just running `mdbook test` which now passes! Let me know if you want me to add mdbook test to ci as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust reference repo has
mdbook testas part of its CI, so when I was working on a PR here,mdbook testbeing broken confused me, so I figured I would make a PR to fix it.I added some ignores to the problematic blocks (basically those with dependencies or using env vars)
and fixed some links to use