Add temporary fix for rustup on windows in CI. #9498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 65ca4e0 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 26, 2021
Update cargo 7 commits in 070e459c2d8b79c5b2ac5218064e7603329c92ae..e931e4796b61de593aa1097649445e535c9c7ee0 2021-05-11 18:12:23 +0000 to 2021-05-24 16:17:27 +0000 - Add `cargo:rustc-link-arg-bin` flag. (rust-lang/cargo#9486) - Add a cargo-doc.browser config option (rust-lang/cargo#9473) - Fix bug when with resolver = "1" non-virtual package was allowing unknown features (rust-lang/cargo#9437) - Add GitHub link to contributor guide. (rust-lang/cargo#9493) - Add temporary fix for rustup on windows in CI. (rust-lang/cargo#9498) - 3 typos and some capitalization (rust-lang/cargo#9495) - fix 6 typos (rust-lang/cargo#9484)
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 26, 2021
Update cargo 7 commits in 070e459c2d8b79c5b2ac5218064e7603329c92ae..e931e4796b61de593aa1097649445e535c9c7ee0 2021-05-11 18:12:23 +0000 to 2021-05-24 16:17:27 +0000 - Add `cargo:rustc-link-arg-bin` flag. (rust-lang/cargo#9486) - Add a cargo-doc.browser config option (rust-lang/cargo#9473) - Fix bug when with resolver = "1" non-virtual package was allowing unknown features (rust-lang/cargo#9437) - Add GitHub link to contributor guide. (rust-lang/cargo#9493) - Add temporary fix for rustup on windows in CI. (rust-lang/cargo#9498) - 3 typos and some capitalization (rust-lang/cargo#9495) - fix 6 typos (rust-lang/cargo#9484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a temporary fix for rustup on the Windows CI runners. The GitHub image updated to rustup 1.24.1 which has an issue (rust-lang/rustup#2759) causing them to fail. This is fixed in 1.24.2. I believe the images are updated on roughly a weekly basis, and from what I can see the image just downloads the most recently release, so hopefully this will be fixed on GitHub's side in roughly a week. Until then, this will force rustup to update.
Note: Self updates aren't available on macOS images, but they seem to work on the others.