Skip to content

remove unnecessary 'collect' #9616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2021
Merged

remove unnecessary 'collect' #9616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a255d96
remove unnecessary 'collect'
danieleades Jun 23, 2021
592b01c
fix inverted logic
danieleades Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/cargo/core/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,16 +841,13 @@ impl CliUnstable {
// some point, and migrate to a new -Z flag for any future
// things.
let feats = parse_features(v);
let stab: Vec<_> = feats
.iter()
.filter(|feat| {
matches!(
feat.as_str(),
"build_dep" | "host_dep" | "dev_dep" | "itarget" | "all"
)
})
.collect();
if !stab.is_empty() || feats.is_empty() {
let stab_is_not_empty = feats.iter().any(|feat| {
matches!(
feat.as_str(),
"build_dep" | "host_dep" | "dev_dep" | "itarget" | "all"
)
});
if stab_is_not_empty || feats.is_empty() {
// Make this stabilized_err once -Zfeature support is removed.
stabilized_warn(k, "1.51", STABILIZED_FEATURES);
}
Expand Down