Skip to content

Conversation

@nathanwhit
Copy link
Contributor

Closes #439.

I'm a bit unsure about a few changes here, namely the lowering and the duplication of the Mutability enum in both the ast module and in chalk-ir, which feels a bit messy.

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one nit

@nathanwhit nathanwhit force-pushed the typename-raw-pointer branch from 5549cb2 to dc3a03b Compare May 7, 2020 23:04
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackh726 jackh726 merged commit 220953b into rust-lang:master May 7, 2020
@nathanwhit nathanwhit deleted the typename-raw-pointer branch May 25, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create typename for raw pointers

2 participants