Add function def clauses #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
commented
May 27, 2020
nikomatsakis
approved these changes
May 28, 2020
bjorn3
reviewed
May 28, 2020
| fn fn_def_is_copy() { | ||
| test! { | ||
| program { | ||
| #[lang(sized)] |
bjorn3
reviewed
May 28, 2020
| fn fn_def_is_clone() { | ||
| test! { | ||
| program { | ||
| #[lang(sized)] |
Member
There was a problem hiding this comment.
This should be clone, not sized.
Member
Author
|
Well shoot...I'll just include these in the chalk-base PR. |
Merged
AzureMarker
reviewed
May 28, 2020
| @@ -0,0 +1,66 @@ | |||
| use super::*; | |||
Contributor
There was a problem hiding this comment.
Another issue, these tests aren't run because the module is not listed in tests/test/mod.rs
Contributor
There was a problem hiding this comment.
They fail in the parser because it expects ; instead of { }.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in #449
Also Sized test for
Never