Remove mulsf3.c and muldf3.c from compiler-rt. #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulsf3 and muldf3 have Rust implementations since 8970485. Remove the C implementations to avoid conflicts.
Member
|
@bors: r+ |
Contributor
|
📌 Commit 0474060 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Nov 26, 2017
…xcrichton Remove mulsf3.c and muldf3.c from compiler-rt. mulsf3 and muldf3 have Rust implementations since 8970485. This PR removes the C implementations to avoid conflicts. Without this I wasn't able to compile the crate with the "c" feature enabled, the errors being `multiple definition of '__muldf3'` and `multiple definition of '__mulsf3'`.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mulsf3 and muldf3 have Rust implementations since 8970485. This PR removes the C implementations to avoid conflicts.
Without this I wasn't able to compile the crate with the "c" feature enabled, the errors being
multiple definition of '__muldf3'andmultiple definition of '__mulsf3'.