Report errors and slow requests on the backend to Sentry #2961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
requested changes
Oct 26, 2020
There was a problem hiding this comment.
The integration code looks good! I think we should make a couple changes to avoid sending sensitive data over to Sentry, and I want to test in staging how it interacts with CloudFront (as it'd be really useful to be able to search events by CloudFront Request ID).
pietroalbini
approved these changes
Oct 26, 2020
|
@bors r=pietroalbini |
|
📌 Commit 29bfde8 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements initial Sentry integration for our backend API via https://github.com/getsentry/sentry-rust.
It will automatically report panics to Sentry, as well as internal server errors (unfortunately without stacktrace for now) and slow requests, similar to our current
println!()logging.r? @pietroalbini