Skip to content

Use HeaderValue::from_static() instead of ::from(&str) #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Use HeaderValue::from_static() instead of ::from(&str) #3956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/admin/render_readmes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ pub fn run(opts: Opts) {
let content = std::io::Cursor::new(readme);
let readme_path = format!("readmes/{0}/{0}-{1}.html", krate_name, version.num);
let mut extra_headers = header::HeaderMap::new();
extra_headers.insert(header::CACHE_CONTROL, CACHE_CONTROL_README.parse().unwrap());
extra_headers.insert(
header::CACHE_CONTROL,
header::HeaderValue::from_static(CACHE_CONTROL_README),
);
base_config
.uploader()
.upload(
Expand Down Expand Up @@ -165,7 +168,10 @@ fn get_readme(
};

let mut extra_headers = header::HeaderMap::new();
extra_headers.insert(header::USER_AGENT, USER_AGENT.parse().unwrap());
extra_headers.insert(
header::USER_AGENT,
header::HeaderValue::from_static(USER_AGENT),
);
let response = match client.get(&location).headers(extra_headers).send() {
Ok(r) => r,
Err(err) => {
Expand Down
7 changes: 5 additions & 2 deletions src/uploaders.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ impl Uploader {
let mut extra_headers = header::HeaderMap::new();
extra_headers.insert(
header::CACHE_CONTROL,
CACHE_CONTROL_IMMUTABLE.parse().unwrap(),
header::HeaderValue::from_static(CACHE_CONTROL_IMMUTABLE),
);
self.upload(
app.http_client(),
Expand All @@ -170,7 +170,10 @@ impl Uploader {
let content_length = readme.len() as u64;
let content = Cursor::new(readme);
let mut extra_headers = header::HeaderMap::new();
extra_headers.insert(header::CACHE_CONTROL, CACHE_CONTROL_README.parse().unwrap());
extra_headers.insert(
header::CACHE_CONTROL,
header::HeaderValue::from_static(CACHE_CONTROL_README),
);
self.upload(
http_client,
&path,
Expand Down