- 
                Notifications
    You must be signed in to change notification settings 
- Fork 216
add download endpoint for rustdoc archive #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| also I imagine in the future we would also run the JSON-build and offer a download too. | 
5c67568    to
    a7b16a2      
    Compare
  
    | invalidation is incomplete, I would like to fix it when #1864 is reviewed & merged & this PR is rebased on it. I would love a review on this PR anyways | 
| Tweaked the permissions. | 
517d344    to
    8cb6bf0      
    Compare
  
    8cb6bf0    to
    7f2074f      
    Compare
  
    | @Nemo157 I updated the branch according to your comments. Ready for another round :) | 
6bdcd9a    to
    7e2ae13      
    Compare
  
    | I've tested this locally with minio and the download is working and I can see the tag being applied when I hit the download endpoint: > mcli tag list docsrs/rust-docs-rs/rustdoc/bpaf/0.6.1.zip
Name                     : http://localhost:9000/rust-docs-rs/rustdoc/bpaf/0.6.1.zip ()
static-cloudfront-access : allow | 
This resolves #174 for offline documentation readers.
The tag specifications & static domain were already set up with @Mark-Simulacrum , see here.
A working download can be seen here, while other crates / versions would get a 403 / forbidden error.
note for deploy:
we need to check with @pietroalbini if the access key on the docs.rs server has the needed permissions:
s3:PutObjectTaggingon the bucketstatic.docs.rscloudfront distribution