Remove miniz-sys, and map it to miniz_oxide for compatibility #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtriplett
force-pushed
the
remove-miniz-sys
branch
from
49271da to
416e23d
Compare
Closed
This eliminates the additional infrastructure needed for maintaining and testing the miniz-sys backend.
With the elimination of miniz-sys, the conditional that used cfg-if now only needs to deal with `any_zlib`, making it simple enough to just drop cfg-if.
joshtriplett
force-pushed
the
remove-miniz-sys
branch
from
416e23d to
9067d1e
Compare
yaahc
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the additional infrastructure needed for maintaining and
testing the miniz-sys backend.