Skip to content

Conversation

@taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 10, 2019

Fixes #1404

select! macro will use the item in futures::{future, task} if imported from futures and the item in futures_util::{future, task} if imported from futures_util. This error was caused by some items not exported in futures_util.

This PR re-exports some items to futures_util, and adds a test of the case where select! macro is imported from futures_util.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 10, 2019

Merging #1407 will fix build failure.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 10, 2019

FYI: 1407 + this PR
(This is the build result of the code which branches from this branch and did git rebase.)

@cramertj
Copy link
Member

Thanks for the fixes!

@cramertj cramertj merged commit 4ff9bb5 into rust-lang:master Jan 14, 2019
@taiki-e taiki-e deleted the select branch January 14, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants