Backport to 0.1: FuturesUnordered: Do not poll the same future twice per iteration #2358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krallin
force-pushed
the
backport-2333
branch
from
30347de to
d6d50f2
Compare
taiki-e
reviewed
Feb 24, 2021
taiki-e
added
futures-0.1
…per iteration Same as rust-lang#2333. The same issue exists in 0.1, so backporting it there helps for code that is still using Futures 0.1 in some places.
krallin
force-pushed
the
backport-2333
branch
from
d6d50f2 to
94f9cec
Compare
|
Whoops, sorry for that! Fixed now :) |
taiki-e
removed
the
S-waiting-on-author
Merged
|
Published in 0.1.31. |
Thanks! =) |
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Mar 4, 2021
Summary: Those newer versions of Futures have compatibility improvements with Tokio, notably: - rust-lang/futures-rs#2333 - rust-lang/futures-rs#2358 Reviewed By: farnz Differential Revision: D26778794 fbshipit-source-id: 5a9dc002083e5edfa5c614d8d2242e586a93fcf6
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Mar 4, 2021
Summary: Those newer versions of Futures have compatibility improvements with Tokio, notably: - rust-lang/futures-rs#2333 - rust-lang/futures-rs#2358 Reviewed By: farnz Differential Revision: D26778794 fbshipit-source-id: 5a9dc002083e5edfa5c614d8d2242e586a93fcf6
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Mar 4, 2021
Summary: Those newer versions of Futures have compatibility improvements with Tokio, notably: - rust-lang/futures-rs#2333 - rust-lang/futures-rs#2358 Reviewed By: farnz Differential Revision: D26778794 fbshipit-source-id: 5a9dc002083e5edfa5c614d8d2242e586a93fcf6
facebook-github-bot
pushed a commit
to facebookincubator/below
that referenced
this pull request
Mar 4, 2021
Summary: Those newer versions of Futures have compatibility improvements with Tokio, notably: - rust-lang/futures-rs#2333 - rust-lang/futures-rs#2358 Reviewed By: farnz Differential Revision: D26778794 fbshipit-source-id: 5a9dc002083e5edfa5c614d8d2242e586a93fcf6
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Mar 4, 2021
Summary: Those newer versions of Futures have compatibility improvements with Tokio, notably: - rust-lang/futures-rs#2333 - rust-lang/futures-rs#2358 Reviewed By: farnz Differential Revision: D26778794 fbshipit-source-id: 5a9dc002083e5edfa5c614d8d2242e586a93fcf6
vkill
pushed a commit
to bk-rs/fbthrift-git-rs
that referenced
this pull request
Mar 23, 2021
Summary: Those newer versions of Futures have compatibility improvements with Tokio, notably: - rust-lang/futures-rs#2333 - rust-lang/futures-rs#2358 Reviewed By: farnz Differential Revision: D26778794 fbshipit-source-id: 5a9dc002083e5edfa5c614d8d2242e586a93fcf6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2333. The same issue exists in 0.1, so backporting it there
helps for code that is still using Futures 0.1 in some places.