Skip to content

Remove implicit clear in ReadyToRunQueue::drop #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2021
Merged

Remove implicit clear in ReadyToRunQueue::drop #2493

merged 2 commits into from
Sep 2, 2021

Conversation

@ibraheemdev
Copy link
Member

Resolves #2473

@ibraheemdev ibraheemdev requested a review from taiki-e as a code owner September 2, 2021 17:17
@taiki-e
Copy link
Member

taiki-e commented Sep 2, 2021 •
edited
Loading

Thanks! Could you also update safety docs on ReadyToRunQueue::clear? (FuturesUnordered::clear -> FuturesUnordered::clear_head_all)

futures-rs/futures-util/src/stream/futures_unordered/ready_to_run_queue.rs

Lines 95 to 97 in cc7e98e

// # Safety
//
// - All tasks **must** have had their futures dropped already (by FuturesUnordered::clear)

@taiki-e taiki-e merged commit 37dfb05 into rust-lang:master Sep 2, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@ibraheemdev @taiki-e
Remove implicit clear in ReadyToRunQueue::drop (#2493)
683d540
@taiki-e taiki-e mentioned this pull request Nov 23, 2021
Merged
@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Nov 23, 2021
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@ibraheemdev @taiki-e
Remove implicit clear in ReadyToRunQueue::drop (#2493)
78fa3cd
taiki-e pushed a commit that referenced this pull request Nov 23, 2021
@ibraheemdev @taiki-e
Remove implicit clear in ReadyToRunQueue::drop (#2493)
9080b83
@taiki-e taiki-e mentioned this pull request Dec 10, 2021
Closed
taiki-e added a commit that referenced this pull request Dec 18, 2021
@taiki-e
Revert "Remove implicit clear in ReadyToRunQueue::drop (#2493)"
ef5b7eb 
This reverts commit 37dfb05.
@taiki-e taiki-e mentioned this pull request Dec 18, 2021
Merged
taiki-e added a commit that referenced this pull request Dec 18, 2021
@taiki-e
Revert "Remove implicit clear in ReadyToRunQueue::drop (#2493)"
e148244 
This reverts commit 37dfb05.
taiki-e added a commit that referenced this pull request Dec 18, 2021
@taiki-e
Revert "Remove implicit clear in ReadyToRunQueue::drop (#2493)"
f742154 
This reverts commit 37dfb05.
@taiki-e taiki-e mentioned this pull request Dec 18, 2021
Merged
taiki-e added a commit that referenced this pull request Dec 18, 2021
@taiki-e
Revert "Remove implicit clear in ReadyToRunQueue::drop (#2493)"
6ffb4c5 
This reverts commit 37dfb05.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees

No one assigned

Labels

0.3-backport: completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Safety risk with reusing ReadyToRunQueue

2 participants

@ibraheemdev @taiki-e