Skip to content

Conversation

@jbaublitz
Copy link
Contributor

Reopening a PR to close #1059. I'll be adding a few more constants but want to make sure CI works on Github first.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented May 22, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented May 22, 2019

📌 Commit 1f997a5 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented May 22, 2019

⌛ Testing commit 1f997a5 with merge 04f47bb...

bors added a commit that referenced this pull request May 22, 2019
Netlink constants for use with the route netlink subsystem

Reopening a PR to close #1059. I'll be adding a few more constants but want to make sure CI works on Github first.
@gnzlbg
Copy link
Contributor

gnzlbg commented May 22, 2019

@bors: force

@gnzlbg gnzlbg closed this May 22, 2019
@gnzlbg gnzlbg reopened this May 22, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented May 22, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented May 22, 2019

💥 Test timed out

@bors
Copy link
Contributor

bors commented May 22, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented May 22, 2019

📌 Commit 1f997a5 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented May 22, 2019

⌛ Testing commit 1f997a5 with merge d14bbca...

bors added a commit that referenced this pull request May 22, 2019
Netlink constants for use with the route netlink subsystem

Reopening a PR to close #1059. I'll be adding a few more constants but want to make sure CI works on Github first.
@bors
Copy link
Contributor

bors commented May 22, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing d14bbca to master...

@bors bors merged commit 1f997a5 into rust-lang:master May 22, 2019
bors added a commit that referenced this pull request May 24, 2019
Add final rtnetlink constants

This is a follow up to the PR #1351 which is for issue #1059 as it was closed before I realized there's one last set of netlink constants needed for use with rtnetlink. I'm marking this as WIP until I've verified everything's good with CI and that I've included all necessary constants. I'll remove WIP once it's passing CI and it's ready for review.
bors added a commit that referenced this pull request May 24, 2019
Add final rtnetlink constants

This is a follow up to the PR #1351 which is for issue #1059 as it was closed before I realized there's one last set of netlink constants needed for use with rtnetlink. I'm marking this as WIP until I've verified everything's good with CI and that I've included all necessary constants. I'll remove WIP once it's passing CI and it's ready for review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route netlink C header #define's PR?

4 participants