Skip to content

Conversation

@devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Some changes occurred in solarish module

cc @jclulow,@pfmooney

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

pub const NET_MAC_AWARE_INHERIT: ::c_uint = 0x0020;
pub const PRIV_AWARE_RESET: ::c_uint = 0x0040;
pub const PRIV_XPOLICY: ::c_uint = 0x0080;
pub const PRIV_PFEXEC: ::c_uint = 0x0080;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 0x0100?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch bad c/p :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the tests? They generally catch transcription errors like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does I do in other platforms but in my illumos VM tests get stuck and mostly I have to reboot the VM.

@devnexen devnexen force-pushed the solarish_priv_flags_upd branch from cff60d9 to bc405e5 Compare January 24, 2022 16:28
@Amanieu
Copy link
Member

Amanieu commented Jan 24, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 24, 2022

📌 Commit bc405e5 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Jan 24, 2022

⌛ Testing commit bc405e5 with merge 831b3a2...

@bors
Copy link
Contributor

bors commented Jan 24, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 831b3a2 to master...

@bors bors merged commit 831b3a2 into rust-lang:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants