Skip to content

Conversation

@bzEq
Copy link

@bzEq bzEq commented Apr 2, 2024

Should use target_os rather than target_env, so that correct libraries are linked.

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor enabled auto-merge April 17, 2024 11:04
@JohnTitor JohnTitor added this pull request to the merge queue Apr 17, 2024
Merged via the queue into rust-lang:main with commit aaae702 Apr 17, 2024
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 13, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 13, 2024
(backport <rust-lang#3646>)
(cherry picked from commit 18dca23)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 13, 2024
(backport <rust-lang#3646>)
(cherry picked from commit 18dca23)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch stable-nominated This PR should be considered for cherry-pick to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch stable-applied This PR has been cherry-picked to libc's stable release branch labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants