Skip to content

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Nov 16, 2024

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Perform the following style changes:

- Only use uppercase variable names if they are exported
- Only use `${...}` syntax when joining with other strings, `$...`
  otherwise
- Use `CARGO_TERM_VERBOSE` rather than always passing `-v`
- Indent is always four spaces
- Fix shellcheck errors in all shell scripts
- Rewrap some long or complex commands
- Replace redundant `| \` with just `|`

(backport <rust-lang#4042>)
(cherry picked from commit eddb526)
(backport <rust-lang#4042>)
(cherry picked from commit 4230b41)
@rustbot rustbot added the A-CI Area: CI-related items label Nov 16, 2024
@tgross35 tgross35 changed the title Update the CI for libc-0.2 to be identical to main [0.2] ci: make scripts more uniform Nov 16, 2024
@tgross35 tgross35 enabled auto-merge November 16, 2024 21:19
@tgross35 tgross35 changed the title [0.2] ci: make scripts more uniform [0.2] Backports Nov 16, 2024
@tgross35 tgross35 added this pull request to the merge queue Nov 16, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 0f15698 Nov 16, 2024
44 checks passed
@tgross35 tgross35 deleted the update-ci branch November 16, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI-related items S-waiting-on-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants