[0.2] Update mach-related deprecation notices
#4097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
These were all removed in `main` in e425743 ("Remove mach-related items") but don't currently have notices. Fix that here. I am not sure whether the _NS constant should be deprecated since it doesn't appear to be in `mach`.
tgross35
force-pushed
the
mach-deprecated
branch
from
c6d08f7 to
4d44be3
Compare
tgross35
changed the title
mach-related deprecation noticesmach-related deprecation notices
|
@tgross35 @JohnTitor some of these methods are not implemented in the mach2 crate yet, they should not have been deprecated here. |
|
Then, we have to declare them on the mach2 crate instead, feel free to send a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all removed in
mainin e425743 ("Remove mach-related items") but don't currently have notices. Fix that here.I am not sure whether the _NS constant should be deprecated since it doesn't appear to be in
mach.