seccomp: Add more constants from seccomp.h #4330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in the Android module cc @maurer |
|
Please also consider this for backporting to 0.2 |
|
Android changes LGTM |
maurer
approved these changes
Mar 16, 2025
tgross35
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Could you update SECCOMP_FILTER_FLAG_TSYNC_ESRCH and SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV to use 1 << 4 and 1 << 5 to be consistent the headers? I know the other constants don't do this yet, they can also be updated if you want.
Otherwise just add a permalink to the headers in the PR description and LGTM.
You can request this via rustbot: @rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
and align Android + Linux
mbuesch
force-pushed
the
seccomp-more-consts
branch
from
fd5dfc7 to
97432d1
Compare
|
Thanks for your review! I changed to filter flags to use shifted ones just like in latest Linus' master branch. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 3, 2025
and align Android + Linux (backport <rust-lang#4330>) (cherry picked from commit 97432d1)
Merged
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and align Android + Linux
Description
Update seccomp constants from seccomp.h and synchronize Linux and Android targets.
Sources
linux/seccomp.h
@rustbot label +stable-nominated