Skip to content

Conversation

@Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Nov 5, 2017

No description provided.

@Susurrus Susurrus changed the title add memfd [WIP] add memfd Nov 5, 2017
@Susurrus Susurrus force-pushed the memfd branch 2 times, most recently from e81cfde to abb580c Compare November 5, 2017 21:41
@Susurrus Susurrus changed the title [WIP] add memfd Add constants for memfd_create syscall Nov 5, 2017
@Susurrus
Copy link
Contributor Author

Susurrus commented Nov 5, 2017

Alright, we're green, finally! Should be good to merge.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 6, 2017

📌 Commit c0935ac has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 6, 2017

⌛ Testing commit c0935ac with merge e38483f...

bors added a commit that referenced this pull request Nov 6, 2017
Add constants for memfd_create syscall
@bors
Copy link
Contributor

bors commented Nov 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e38483f to master...

@bors bors merged commit c0935ac into rust-lang:master Nov 6, 2017
@Susurrus Susurrus deleted the memfd branch November 6, 2017 05:24
@Susurrus
Copy link
Contributor Author

Susurrus commented Nov 6, 2017

@alexcrichton So I left off many of the musl targets because these constants aren't declared there. However, since this is a kernel interface, I'd imagine it's appropriate for those targets as well. Is that a correct understanding?

@alexcrichton
Copy link
Member

Yeah I think that'd be fine.

bors bot added a commit to nix-rust/nix that referenced this pull request Nov 7, 2017
794: Migrate memfd constants to libc r=Susurrus a=Susurrus

This will fail because rust-lang/libc#836 is not merged yet, but just getting it staged for when it is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants