[test] Check content of error message #2579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in ask_the_preprocessor_to_blow_up
Alternatively we could change the error message to only include take the status code from the os by using output.status.code().unwrap() in preprocess/cmd.rs where this error message is generated. In that case we could have the exact same error message on all the OS-es.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing error message of ask_the_preprocessor_to_blow_up
Apparently the
output.statusis different on windows and the rest of the OSes. That's why we need thecfg!(windows)We could replace
output.statusbyoutput.status.code().unwrap_or(-1)or byoutput.status.code().unwrap()thereby making sure the error message is the same on all (currently tested) OSes.