add additinonal data to crox events #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
approved these changes
Jan 15, 2020
|
@michaelwoerister how do you feel about having the seperators inform about the type of argument that will come e.g. so def_id can be printed insted of arg0 |
|
I think the main problem is that we don't have the parameter name available at the time of recording. In many cases we don't even define a name for the argument (and most of the time it's just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hade been nice to have some reserved names (eg. def_id, cgu_id ...) for the additional data now I have only enumerated them.
eg. of how it looks in chrome://tracing/
