Switch CI to merge queues #3981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2024
RalfJung
reviewed
Oct 21, 2024
Kobzol
force-pushed
the
ci-merge-queue
branch
from
6494507 to
ac39872
Compare
RalfJung
reviewed
Oct 22, 2024
Member
RalfJung
left a comment
RalfJung
left a comment
There was a problem hiding this comment.
Okay, I have one more comment nit that helps explain why we need the if: at all.
With that nit applied, feel free to land this and do the infra-side changes whenever it is convenient for you.
RalfJung
reviewed
Oct 22, 2024
Kobzol
force-pushed
the
ci-merge-queue
branch
from
ac39872 to
4b9dc19
Compare
Member
Author
|
Added the all caps part and your suggestion for the comment. Thanks for the review! |
marcoieni
approved these changes
Oct 22, 2024
Member
marcoieni
left a comment
marcoieni
left a comment
There was a problem hiding this comment.
great description. We could copy it to other rust repos as well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged in cooperation with an infra admin.